Feat: Channel Points Automatic Reward Redemption #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djinnet
changed the title
AoshiW
suggested changes
May 20, 2024
Comment on lines
4
to
5
| namespace TwitchLib.EventSub.Websockets.Core.EventArgs.Channel; | ||
| public class ChannelPointsAutomaticRewardRedemptionArgs : TwitchLibEventSubEventArgs<EventSubNotification<ChannelPointsAutomaticRewardRedemption>> |
There was a problem hiding this comment.
missing new line
Suggested change
| namespace TwitchLib.EventSub.Websockets.Core.EventArgs.Channel; | |
| public class ChannelPointsAutomaticRewardRedemptionArgs : TwitchLibEventSubEventArgs<EventSubNotification<ChannelPointsAutomaticRewardRedemption>> | |
| namespace TwitchLib.EventSub.Websockets.Core.EventArgs.Channel; | |
| public class ChannelPointsAutomaticRewardRedemptionArgs : TwitchLibEventSubEventArgs<EventSubNotification<ChannelPointsAutomaticRewardRedemption>> |
|
@AoshiW Thanks for letting me know about the handler. I wasnt aware that it need an handler, since I am not entire familiar with the codebase yet. I tried to make the handler based of ChannelPointsCustomRewardRedemptionAddHandler.cs, but with automatic rewards. |
…r.cs Couldnt be me who forgot the summary...
|
Just out of curiosity, is there more anything that this pull request needs to be tweaked in order to get merged or has it been forgotten to be merged since may? I am just asking because last time I touched this pull request was in may and now it is almost at the end of june, so I am little curious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the websocket dev branch has been updated to latest changes from dev core in #33 , I do hope it is okay that I am submitted this pull request. Strike while the iron is hot, I suppose.
Let me know if there are anything that should be modified/changed, so it looks good with the rest of the structure that is already in place.